Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First few changes from the Churn workflow #8782

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jan 16, 2024

Pull Request Description

  • up_to should have the step as an optional argument.
  • Date_Range conversion can do a clever auto rename, so if a period use the name of it.
  • Add to Table for Range, Date_Range.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 16, 2024
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think we should add tests for the range->column|table conversions somewhere, especially the auto-naming logic.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jan 17, 2024
@jdunkerley jdunkerley force-pushed the wip/jd/churn-changes branch from 5b2af6e to d8e1147 Compare January 17, 2024 18:27
@mergify mergify bot merged commit d55c9c9 into develop Jan 17, 2024
24 of 25 checks passed
@mergify mergify bot deleted the wip/jd/churn-changes branch January 17, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants